Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46116 )
Change subject: mb/ocp/deltalake: Override cache operation mode in SMBIOS type 7
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46116/1/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/46116/1/src/mainboard/ocp/deltalake...
PS1, Line 260: }
Isn’t that chipset or CPU dependent? Why does it go into the mainboard?
This should be in Xeon-SP code
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d8d2b1c114b9c0c740841a9121d945adaea1d6c
Gerrit-Change-Number: 46116
Gerrit-PatchSet: 1
Gerrit-Owner: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Oct 2020 13:22:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment