Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45138 )
Change subject: arch/x86/smbios: Update SMBIOS type 0 ec version
......................................................................
Patch Set 4:
Patch Set 4:
(4 comments)
Patch Set 2:
(3 comments)
Patch Set 2:
Not sure it is ok to use BMC version directly?
I've no idea if it's correct to use the BMC version here. If SMBIOS says this is for the Embedded Controller, then we shouldn't write the BMC information
In YV3, there's no EC. BMC is used to represent EC in YV3, so I think maybe it is fine to use BMC version here. If it's not suitable I'll remove it.
The SMBIOS spec does not have a BMC field in type 0. Traditional firmware does use this "EC version field" to hold BMC version, so we are consistent here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd5ee27a1b8fa4e5bc66e359d3b62e052e19e8a2
Gerrit-Change-Number: 45138
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Sep 2020 17:34:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment