Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44922 )
Change subject: arch/x86/exit_car.S: Fix checking clflush support
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44922/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44922/1//COMMIT_MSG@9
PS1, Line 9: it
its
Done
https://review.coreboot.org/c/coreboot/+/44922/1//COMMIT_MSG@10
PS1, Line 10: correct jump instruction.
this would have broken any real hardware using cpus before the pentium4. […]
Done
https://review.coreboot.org/c/coreboot/+/44922/1//COMMIT_MSG@11
PS1, Line 11:
It’d be great, if you added a `Fixes:` tag.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44922
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I704e3c579150fb9b9a292ef0e83050e7bf7cb078
Gerrit-Change-Number: 44922
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: ky0ko
ky0ko@disroot.org
Gerrit-Comment-Date: Sat, 29 Aug 2020 08:20:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ky0ko
ky0ko@disroot.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment