[coreboot-gerrit] Change in coreboot[master]: drivers/generic/max98357a: Allow custom _HID from config

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39286 )

Change subject: drivers/generic/max98357a: Allow custom _HID from config
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39286/11/src/drivers/generic/max983... 
File src/drivers/generic/max98357a/max98357a.c:

https://review.coreboot.org/c/coreboot/+/39286/11/src/drivers/generic/max983... 
PS11, Line 46: if (!config->hid)
             : 		acpigen_write_name_string("_HID", MAX98357A_ACPI_HID);
             : 	else
             : 		acpigen_write_name_string("_HID", config->hid);
> Paul/Tim, […]

I had another thought... what about a "variant" option in chip.h that has enumerated values for 
MAX98357A, MAX98357B. Then here it could write out the HID appropriate for each MAX chip variant, with the default being the one that uses the MAX9357A_ACPI_HID.