Attention is currently required from: Tim Wawrzynczak, Paul Menzel. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62931 )
Change subject: mb/google/brya: Add PEG and initial Nvidia dGPU ASL support ......................................................................
Patch Set 2:
(4 comments)
File src/mainboard/google/brya/acpi/gpu_top.asl:
https://review.coreboot.org/c/coreboot/+/62931/comment/cb8cc657_8a60f71c PS2, Line 3: #define NV_ERROR_SUCCESS 0x0 : #define NV_ERROR_UNSPECIFIED 0x80000001 : #define NV_ERROR_UNSUPPORTED 0x80000002 suggestion: may be `enum`?
https://review.coreboot.org/c/coreboot/+/62931/comment/6980deb0_d8ac0384 PS2, Line 16: #define GC6_STATE_EXITED 0x0 : #define GC6_STATE_ENTERED 0x1 : #define GC6_STATE_TRANSITION 0x2 same?
and may be applicable to most of macros here?
https://review.coreboot.org/c/coreboot/+/62931/comment/60ff56a2_53d50d06 PS2, Line 45: Device (PEGP) if code block inside `PEGP` remains generic then I would suggest to split this file into 3 files 1. `.h` to have the macro definitions 2. `Device (PEGP)` code block between line #45-#78 in a pegp.asl file 3. include `pegp.asl` from brya DSDT under scope `_SB.PCI0.PEG1`
File src/mainboard/google/brya/acpi/power.asl:
https://review.coreboot.org/c/coreboot/+/62931/comment/233d6d1b_374dbd4e PS2, Line 227: multiple blank line?