14 Aug
2019
14 Aug
'19
4:57 a.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34636 )
Change subject: mb/ocp/monolake: use RW_VPD to configure FSP UPD ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34636/13/src/mainboard/ocp/monolake... File src/mainboard/ocp/monolake/vpd_fsp.h:
https://review.coreboot.org/c/coreboot/+/34636/13/src/mainboard/ocp/monolake... PS13, Line 20: HyperThreading FYI in Chrome OS we usually prefer to name VPD values in lower_case_with_underline. But since this is a board-specific thing, I'm OK if you want to use CamelCase.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34636
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I799d27734fe4b67cd1f40cae710151a01562b1b2
Gerrit-Change-Number: 34636
Gerrit-PatchSet: 13
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin huang.jin@intel.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Martin Roth martin.roth@tinkermill.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: Łukasz Siudut
Gerrit-Comment-Date: Wed, 14 Aug 2019 04:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment