Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48246 )
Change subject: soc/intel/common/block/acpi: Add soc MADT IOAPIC hook ......................................................................
Patch Set 9: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/48246/9/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/48246/9/src/soc/intel/common/block/... PS9, Line 91: nit: extra tab not required here and on next line.
https://review.coreboot.org/c/coreboot/+/48246/9/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/acpi.h:
https://review.coreboot.org/c/coreboot/+/48246/9/src/soc/intel/common/block/... PS9, Line 77: */ nit: It might be helpful to add the information here that if SoC does not provide a custom implementation of this, then the default uses id=2, addr=IO_APIC_ADDR, gsi_base=0
https://review.coreboot.org/c/coreboot/+/48246/9/src/soc/intel/common/block/... PS9, Line 78: struct madt_ioapic_info *
This could be `const` to allow implementations with static tables, AFAICS.
+1