12 Apr
2019
12 Apr
'19
8:48 a.m.
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )
Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32292/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32292/3/src/mainboard/google/hatch/variants/... PS3, Line 150: 20K_PU
UP_20K ?
yeah, I just found the error and fixed it
--
To view, visit https://review.coreboot.org/c/coreboot/+/32292
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756
Gerrit-Change-Number: 32292
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Chen philipchen@google.com
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-Comment-Date: Fri, 12 Apr 2019 06:48:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen shchen@google.com
Gerrit-MessageType: comment