Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38471 )
Change subject: soc/amd/picasso: Add SMMSTORE support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38471/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38471/1//COMMIT_MSG@12
PS1, Line 12: duplicates
Once there's deduplication going on, sure. […]
Patrick, yes that's 100% correct. I'd made a conscious decision balancing keeping copies in sync vs. trying to commonize features where the register sets didn't match. More specifically, since the SMI block of registers are defined only somewhat similarly, (when the time comes) having two functioning platforms will help me decide what part moves to common and what part must remain in the amd/<apu_name> directory.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id05b33edf949611c3f9eac94e7b63a4266c6c4d0
Gerrit-Change-Number: 38471
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jan 2020 16:28:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment