Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31885 )
Change subject: ec/google/chromeec: Update ec_commands.h
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31885/2/src/ec/google/chromeec/comp...
File src/ec/google/chromeec/compile_time_macros.h:
https://review.coreboot.org/c/coreboot/+/31885/2/src/ec/google/chromeec/comp...
PS2, Line 36: ## line
This file is removed in the next patchset.
But I'll try to change this in chromiumos ec repo.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ed5344fc8923e45e17c3e2a34371db6f80b079d
Gerrit-Change-Number: 31885
Gerrit-PatchSet: 6
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 22 Aug 2019 06:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment