Attention is currently required from: Poornima Tom, Vamshi Krishna Gopal.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79723?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox: Enable HDA Codec ALC256
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79723/comment/d3193341_71d447ce :
PS5, Line 9: Add verb table for the same.
ALC256 file based on which the verb table generated is added in cross bug.
Just in case you didn’t know, a lot of people are denied access to these issues.
https://review.coreboot.org/c/coreboot/+/79723/comment/954f46ba_6d83d114 :
PS5, Line 14: To verify HDA on Brox
Yes, It needs to be tested based on the board availability. […]
Shelly, were you able to test it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79723?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1edd5aee053debe39b34048266703031c088cd00
Gerrit-Change-Number: 79723
Gerrit-PatchSet: 6
Gerrit-Owner: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.com
Gerrit-Reviewer: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.com
Gerrit-Comment-Date: Mon, 29 Jan 2024 10:56:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Poornima Tom
poornima.tom@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment