James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34884 )
Change subject: superio/ite/it8728f: hook up power_on_after_fail ......................................................................
Patch Set 1:
(1 comment)
This is copied from it8720f, the registers are the same. Tested with GA-P67A-UD3R (out-of-tree at this time).
https://review.coreboot.org/c/coreboot/+/34884/1/src/superio/ite/it8728f/sup... File src/superio/ite/it8728f/superio.c:
https://review.coreboot.org/c/coreboot/+/34884/1/src/superio/ite/it8728f/sup... PS1, Line 30: #define MAINBOARD_POWER_KEEP 2 These defines are currently scattered all around the source tree. It would be better if they could be moved into a single header file, given they're not exclusive to any particular hardware configuration?