Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40338 )
Change subject: cpu/x86/acpi: Add function to get sleep number from Pm1 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40338/1/src/arch/x86/include/arch/a... File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/c/coreboot/+/40338/1/src/arch/x86/include/arch/a... PS1, Line 956: ACPI_S0 Instead of adding acpi_snum_from_pm1, can we just guarantee the values of these? ACPI_S0 = 0, ACPI_S1 = 1, ACPI_S5 = 5,
It avoids the switch statement in `send_sx_info`
It would also be nice to name this enum so it could be used as a type. This doesn't have to be done in this CL though.