Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31489 )
Change subject: [WIP] soc/amd/common: Use static allocation for params ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31489/5/src/soc/amd/common/block/pi... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/c/coreboot/+/31489/5/src/soc/amd/common/block/pi... PS5, Line 425: : : : : : : :
I finally had a chance to test it, and as I suspected it would, it hanged at amd_init_early. […]
Ok.. I had forgotten about the multiprocessor-init in romstage. APs would overwrite BSP structure, if we place it in bss. I may play around with this a little more, to see if I get relevant performance boost.
The location of AGESA heap for cold boots is a bit of a problem since coreboot is not really aware of that, currently. SECURITY_CLEAR_DRAM_ON_REGULAR_BOOT feature would not work. See comments in CB:33956.