Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37649 )
Change subject: mb/google/octopus/variants/bobba: fix LTE power sequence ......................................................................
mb/google/octopus/variants/bobba: fix LTE power sequence
fix Power_off section power sequence.
BUG=b:144327240 BRANCH=octopus TEST=build image and verify on the DUT with LTE DB.
Change-Id: I287ba1cb092a95b3a9dd1f960a3b84fd85b9b221 Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/bobba/Makefile.inc M src/mainboard/google/octopus/variants/bobba/variant.c 2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/37649/1
diff --git a/src/mainboard/google/octopus/variants/bobba/Makefile.inc b/src/mainboard/google/octopus/variants/bobba/Makefile.inc index ba865e9..7ee7e70 100644 --- a/src/mainboard/google/octopus/variants/bobba/Makefile.inc +++ b/src/mainboard/google/octopus/variants/bobba/Makefile.inc @@ -2,3 +2,5 @@
ramstage-y += gpio.c ramstage-y += variant.c + +smm-y += variant.c diff --git a/src/mainboard/google/octopus/variants/bobba/variant.c b/src/mainboard/google/octopus/variants/bobba/variant.c index 1f6e80d..fafaf03 100644 --- a/src/mainboard/google/octopus/variants/bobba/variant.c +++ b/src/mainboard/google/octopus/variants/bobba/variant.c @@ -19,6 +19,7 @@ #include <baseboard/variants.h> #include <delay.h> #include <gpio.h> +#include <ec/google/chromeec/ec.h>
enum { SKU_37_DROID = 37, /* LTE */ @@ -74,7 +75,10 @@ if (slp_typ != ACPI_S5) return;
- switch (get_board_sku()) { + static uint32_t sku_id = 255; + google_chromeec_cbi_get_sku_id(&sku_id); + + switch (sku_id) { case SKU_37_DROID: case SKU_38_DROID: case SKU_39_DROID: