Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47956 )
Change subject: fw_config: Use UNDEFINED_FW_CONFIG to mean unprovisioned
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47956/6/src/include/fw_config.h
File src/include/fw_config.h:
https://review.coreboot.org/c/coreboot/+/47956/6/src/include/fw_config.h@60
PS6, Line 60: is
if
Done
https://review.coreboot.org/c/coreboot/+/47956/3/src/lib/fw_config.c
File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/47956/3/src/lib/fw_config.c@75
PS3, Line 75: bool fw_config_probe(const struct fw_config *match)
see below.
Ack
https://review.coreboot.org/c/coreboot/+/47956/3/src/lib/fw_config.c@132
PS3, Line 132: fw_config_probe
Nope, this is the case when we *do* want all devices enabled. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47956
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3046233667e97a5f78961fabacbeb3099b3d442
Gerrit-Change-Number: 47956
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Dec 2020 16:52:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment