build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40036 )
Change subject: [WIP]acpi: Get rid of boilerplate FADT ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40036/1/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/c/coreboot/+/40036/1/src/arch/x86/acpi.c@1272 PS1, Line 1272: switch (DIV_ROUND_UP(reg->bit_width, 8)) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/40036/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/40036/1/src/southbridge/intel/lynxp... PS1, Line 807: pch_is_lp() ? (2 * 4 * sizeof(uint32_t)) : (2 * 2 * sizeof(uint32_t)), line over 96 characters