Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47956 )
Change subject: fw_config: Use UNDEFINED_FW_CONFIG to mean unprovisioned
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47956/7/src/include/fw_config.h
File src/include/fw_config.h:
https://review.coreboot.org/c/coreboot/+/47956/7/src/include/fw_config.h@61
PS7, Line 61: %
Is this a typo?
it is from kernel-doc style comments, %CONST to reference a constant, similar to the @parameter use. we don't actually do much with it yet in coreboot but it would be nice if we did someday..
https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47956
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3046233667e97a5f78961fabacbeb3099b3d442
Gerrit-Change-Number: 47956
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Dec 2020 18:39:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment