Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32513 )
Change subject: soc/intel/cannonlake: Support different SPD read type for each slot ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/cnl_memcfg_... File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/cnl_memcfg_... PS6, Line 77: break; see comment in cnl_memcfg_init. With channel_empty dropped, there's no need to pass struct cnl_mb_cfg *cnl_cfg any more.
https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/cnl_memcfg_... PS6, Line 100: mem_slot add a define to the header for the amount of slots
https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/include/soc... File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:
https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/include/soc... PS6, Line 130: * to indicate that the channel is populated. For example, can be removed, as spd now contains that information