Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik.
hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86510?usp=email )
Change subject: mb/google/nissa/var/pujjoniru: Modify the gpio of GPIO_PCH_WP ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86510/comment/e0d3a073_0c8cc76b?usp... : PS3, Line 15: Build coreboot, flash, boot to : and log into kernel, execute "wp enable" in console, : execute "crossystem" at kernel prompt and verify that "wpsw_cur" : shows as being "1", Execute "wp disable" in console, execute : "crossystem" at kernel prompt and verify "wpsw_cur" is 0.
wp status update verified by toggling it on and off.
Done
File src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/86510/comment/323a43b3_c3c7e3cf?usp... : PS3, Line 14: #if CONFIG(BOARD_GOOGLE_PUJJONIRU) : #define GPIO_PCH_WP GPP_E17 : #else : #define GPIO_PCH_WP GPP_E12 : #endif
Instead of adding a condition to the baseboard, we can update the WP GPIO at a specific variant leve […]
I have tried the modification as you mentioned, but this method did not work in pujjoniru.
At the same time, based on the method you mentioned, we tried to add `#include <variant/gpio.h>` to `mainboard/google/brya/chromeos.c`, because `chromeos.c` calls `GPIO_PCH_WP`, but this problem has not been solved either. ``` #include <variant/gpio.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <gpio.h> #include <types.h> ```