Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47984 )
Change subject: mb/clevo/cml-u: Configure IRQ as level triggered for HID over I2C
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47984/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47984/6//COMMIT_MSG@21
PS6, Line 21: successfully
But... what is success? If this change fixes something, please write it down.
Well, in this case success is "it doesn't break and doesn't cause dmesg warnings/errors". This change is more like "do it right and comply to spec" than a fix for an actual problem.
Also see related changes CB:47415, CB:47416, ... and discussion here https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47984
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia232c0a11546aa6d17614f4cab07c255e58f2fed
Gerrit-Change-Number: 47984
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 03 Jan 2021 13:37:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment