Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46698 )
Change subject: soc/intel/broadwell: Drop chip.c file
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46698/8/src/soc/intel/broadwell/sys...
File src/soc/intel/broadwell/systemagent.c:
https://review.coreboot.org/c/coreboot/+/46698/8/src/soc/intel/broadwell/sys...
PS8, Line 481: dev->ops == NULL || dev->ops->enable == NULL
This looks odd, how could these be set already?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46698
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic844cc3bbff760fa0eed9d81208bbeef39577e9d
Gerrit-Change-Number: 46698
Gerrit-PatchSet: 8
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 25 Oct 2020 13:00:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment