build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45658 ) Change subject: Port of Kontron bSC2 COMe module ...................................................................... Patch Set 3: (17 comments) https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... File src/mainboard/kontron/bSC2/early_init.c: https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 33: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x1403); /* COMA, COMB, KBC and LPC 0x2E enabled */ line over 96 characters https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 34: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0010); /* LPC decode ranges COMA=3F8, COMB=2F8 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... File src/mainboard/kontron/bSC2/hda_verb.c: https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 1: ## SPDX-License-Identifier: GPL-2.0-only spaces required around that ':' (ctx:VxW) https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... File src/mainboard/kontron/bSC2/mainboard.c: https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 1: ## SPDX-License-Identifier: GPL-2.0-only spaces required around that ':' (ctx:VxW) https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 43: #define adt7490_write_byte(reg, val) do_smbus_write_byte(smbus_io_base, adt7490_address, reg, val) line over 96 characters https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 103: if ((vendid = 0x41) && // Analog Devices code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 103: if ((vendid = 0x41) && // Analog Devices please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 103: if ((vendid = 0x41) && // Analog Devices do not use assignment in if condition https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 104: (devid2 & 0xfc) == 0x6c) { // Device ID code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 104: (devid2 & 0xfc) == 0x6c) { // Device ID please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 110: adt7490_write_byte(CONF_REG_1, 0x15); // Monitoring and PWM control outputs enabled line over 96 characters https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 111: adt7490_write_byte(PWM1_CONF_REG, 0x42); // 250ms spin time, Remote 2 temp. controls PWM1 line over 96 characters https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 112: adt7490_write_byte(R2_TRAN_PWM3_FREQ, 0xB4); // Frequency = 35.3 Hz, low frequency PWM mode, line over 96 characters https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 116: adt7490_write_byte(R2_TEMP_TMIN, 0x37); // When the temperature measured exceeds T MIN , the line over 96 characters https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 117: // appropriate fan runs at minimum speed and line over 96 characters https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 118: // increases with temperature according to T RANGE. line over 96 characters https://review.coreboot.org/c/coreboot/+/45658/3/src/mainboard/kontron/bSC2/... PS3, Line 121: adt7490_write_byte(THERM_TIMER_LIMIT, 0xFF); // Avoid unwanted alerts from being generated. line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/45658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2932af6016b044fa807da00acc7b147ef1c7c45e Gerrit-Change-Number: 45658 Gerrit-PatchSet: 3 Gerrit-Owner: Jose Trujillo Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 23 Sep 2020 17:40:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment