4 Apr
2023
4 Apr
'23
9:43 a.m.
Attention is currently required from: Patrick Rudolph, Paul Menzel, David Hendricks, Shuo Liu, Nill Ge.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73392 )
Change subject: mb/ibm: Add IBM SBP1 ......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/ibm/sbp1/include/spr_sbp1_gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173150): https://review.coreboot.org/c/coreboot/+/73392/comment/d0732f13_c979260d PS8, Line 243: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_RX_STATE | \ Avoid unnecessary line continuations
--
To view, visit https://review.coreboot.org/c/coreboot/+/73392
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie21c744224e8d9e5232d63b8366d2981c9575d70
Gerrit-Change-Number: 73392
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nill Ge geshijian@bytedance.com
Gerrit-Reviewer: Shuo Liu shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang jon.zhixiong.zhang@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: David Hendricks david.hendricks@gmail.com
Gerrit-Attention: Shuo Liu shuo.liu@intel.com
Gerrit-Attention: Nill Ge geshijian@bytedance.com
Gerrit-Comment-Date: Tue, 04 Apr 2023 07:43:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment