Po Xu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46390 )
Change subject: soc/mediatek: Move auxadc driver from MT8183 to common
......................................................................
Patch Set 30:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46390/29/src/soc/mediatek/mt8183/in...
File src/soc/mediatek/mt8183/include/soc/auxadc.h:
https://review.coreboot.org/c/coreboot/+/46390/29/src/soc/mediatek/mt8183/in...
PS29, Line 21: mt8183_infracfg_regs
yes, […]
update:
no,
Since mt8192 has mt8192_infracfg_regs,
So it needs to be written separately, and then I define a common variable to make the .c file common.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4553e99c3578fa40e28b19a6e010b52650ba41e
Gerrit-Change-Number: 46390
Gerrit-PatchSet: 30
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Po Xu
jg_poxu@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Nov 2020 06:39:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Po Xu
jg_poxu@mediatek.com
Gerrit-MessageType: comment