Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31534 )
Change subject: soc/intel/cannonlake: Set FSP-S Enable8254ClockGating using clock_gate_8254 devicetree parameter ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31534/1/src/soc/intel/cannonlake/fsp_params.... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/31534/1/src/soc/intel/cannonlake/fsp_params.... PS1, Line 132: params->Enable8254ClockGating = config->clock_gate_8254; : params->Enable8254ClockGatingOnS3 = config->clock_gate_8254; are these always synchronized? Assume there's a use case where they aren't, if there are separate UPDs