Hello Randall Spangler, Patrick Rudolph, Aaron Durbin, Julius Werner, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Simon Glass,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32723
to look at the new patch set (#2).
Change subject: vboot: remove OPROM-related code ......................................................................
vboot: remove OPROM-related code
As of CL:1605641, vboot2 code should be used for setting and checking display init state. Remove all vboot1 OPROM-related code, and use the vboot2 display init code which has already been added in previous commits.
coreboot should not be reading vboot NVRAM flags directly. Remove the function vboot_wants_oprom(), and instead rely on display_init_required(), which uses the VBOOT_WD_FLAG_DISPLAY_INIT value stored in vboot_working_data.flags, initialized during verstage. Note that this means in the case of CONFIG_VBOOT=y, the return value of display_init_required() can only be trusted after verstage has been executed. This should not be a problem assuming that all display initialization occurs in ramstage.
BUG=b:124141368, b:124192753, chromium:948529 TEST=Build locally TEST=make clean && make test-abuild BRANCH=none
Change-Id: Ic8f9dc5a3c7f1546a8fed82bde02be4d04568f8d Signed-off-by: Joel Kitching kitching@google.com Cq-Depend: chromium:1605641, chromium:1605525 --- M src/device/pci_device.c M src/security/vboot/vbnv.c M src/security/vboot/vbnv.h M src/security/vboot/vboot_handoff.c M src/soc/intel/broadwell/igd.c 5 files changed, 1 insertion(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/32723/2