Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30432 )
Change subject: drivers/smmstore: Fix some issues
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30432/15/src/drivers/smmstore/store...
File src/drivers/smmstore/store.c:
https://review.coreboot.org/c/coreboot/+/30432/15/src/drivers/smmstore/store...
PS15, Line 97: *bufsize = 0;
I got rid of it because the variable tx was always 0. […]
It was more of a larger question I don't have an answer on. The SMI callee (from OS or something else) may expect the object to be 0'd. It was sort of implicit as I don't see a comment w.r.t. expectations. Patrick should know what the expectations are of the callee.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I629be25d2a9b65796ae8f7a700b6bdab57b91b22
Gerrit-Change-Number: 30432
Gerrit-PatchSet: 16
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Sep 2019 20:26:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment