build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45352 )
Change subject: nb/intel/haswell: Guard DMIBAR/EPBAR macro parameters ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45352/2/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/45352/2/src/northbridge/intel/haswe... PS2, Line 60: #define EPBAR8(x) *((volatile u8 *)(DEFAULT_EPBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45352/2/src/northbridge/intel/haswe... PS2, Line 61: #define EPBAR16(x) *((volatile u16 *)(DEFAULT_EPBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45352/2/src/northbridge/intel/haswe... PS2, Line 62: #define EPBAR32(x) *((volatile u32 *)(DEFAULT_EPBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45352/2/src/northbridge/intel/haswe... PS2, Line 91: #define DMIBAR8(x) *((volatile u8 *)(DEFAULT_DMIBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45352/2/src/northbridge/intel/haswe... PS2, Line 92: #define DMIBAR16(x) *((volatile u16 *)(DEFAULT_DMIBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45352/2/src/northbridge/intel/haswe... PS2, Line 93: #define DMIBAR32(x) *((volatile u32 *)(DEFAULT_DMIBAR + (x))) Macros with complex values should be enclosed in parentheses