[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Add code for early tcss

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42079 )

Change subject: soc/intel/tigerlake: Add code for early tcss
......................................................................

Patch Set 25:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/ea... 
File src/soc/intel/tigerlake/early_tcss.c:

https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/ea... 
PS25, Line 157: malloc
a local variable is sufficient here

https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/ea... 
PS25, Line 245: malloc
a local variable is sufficient here.

https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/ea... 
PS25, Line 249: mux_data.usb
you can add
|| mux_data.dp
here and remove the special case call from the dp case below.

also, since we don't need usb until we get to depthcharge, would
it make sense to ignore "mux_data.usb" entirely?

it would help to add a note here that in order to get into
ALT mode, the mux has to transition through the USB and SAFE
states.