Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34286 )
Change subject: soc/intel/icelake: Make use of PCH_DEV_SLOT_ESPI macro
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34286/1/src/soc/intel/icelake/romst...
File src/soc/intel/icelake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/34286/1/src/soc/intel/icelake/romst...
PS1, Line 41: cidev_on_root(PCH_DEV_SLOT_ESPI, 3)
Just use: pcidev_path_on_root(PCH_DEVFN_HDA);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3be530072a6981760e9fe31e43741b4b480d045e
Gerrit-Change-Number: 34286
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 12 Jul 2019 13:51:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment