Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40585 )
Change subject: soc/intel/tigerlake: Add SoundWire ACPI support ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40585/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/hda_soundwire_ctrl.asl:
https://review.coreboot.org/c/coreboot/+/40585/2/src/soc/intel/tigerlake/acp... PS2, Line 57: Bits 0-3 - Device Instance ID (unique to virtual bus). : * SoundWire: : * 0-3 = Bus Instance 0 - 3 : * For example: : * 1) SWC0: _ADR(0x10000000) - LinkType[31:28] = 1 (DSP), Instance[3:0] = 0 : * 2) SWC1: _ADR(0x40000001) - LinkType[31:28] = 4 (SW), Instance[3:0] = 1 : * 3) SWC2: _ADR(0x40000002) - LinkType[31:28] = 4 (SW), Instance[3:0] = 2 This seems to conflict with the guidance here: https://patchwork.kernel.org/patch/10929495/
And we only end up with a single device with _ADR 0x400000000. Is it possible to ever see 0x400000001 and the kernel driver should not be stopping at the first found device?