Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40351 )
Change subject: mb/dell/optiplex_9010: Add Dell OptiPlex 9010 SFF support ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40351/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40351/13//COMMIT_MSG@12 PS13, Line 12: 7010
7010?
Yes, 7010 and 9010 are mostly the same. The board design is almost the same, GPIO configuration is identical.
https://review.coreboot.org/c/coreboot/+/40351/13/src/mainboard/dell/optiple... File src/mainboard/dell/optiplex_9010/sch5545_ec.c:
https://review.coreboot.org/c/coreboot/+/40351/13/src/mainboard/dell/optiple... PS13, Line 576: "failure\n");
Oh, I thought the failure case is just different firmware version.
After power failure the firmware version read from EC will be 0x0000. EC lost its configuration due to power cut off and that is why uploading firmware is necessary. I will add a comment to clarify.