Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51371 )
Change subject: cpu/intel/microcode: Fix caching logic in intel_microcode_find
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/cpu/intel/microcode/microcode.c:
https://review.coreboot.org/c/coreboot/+/51371/comment/671e5da7_f705c387
PS2, Line 120: __
Looks like, as per section 7.1.3 of the C standard, identifiers with two leading underscores are always reserved:
All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use.
Taken from: https://stackoverflow.com/questions/25090635/use-and-in-c-programs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51371
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8600c830ba029e5cb9c0d7e0f1af18d87c61ad3a
Gerrit-Change-Number: 51371
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 09 Mar 2021 10:03:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment