Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37265 )
Change subject: soc/intel/cannonlake: Fix compilation
......................................................................
Patch Set 2:
(2 comments)
Please add a separate CL that has jenkins buildtest CONFIG_FSP_CAR. Do this by adding a config to configs/.
https://review.coreboot.org/c/coreboot/+/37265/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37265/2//COMMIT_MSG@9
PS2, Line 9: change
Capital letter.
https://review.coreboot.org/c/coreboot/+/37265/2//COMMIT_MSG@12
PS2, Line 12: FSP_CAR
CONFIG_FSP_CAR. Add this to the CL title.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37265
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebbf5c34e289870a4d7abdd49fd81e4db236051a
Gerrit-Change-Number: 37265
Gerrit-PatchSet: 2
Gerrit-Owner: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 27 Nov 2019 08:40:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment