Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33233 )
Change subject: soc/intel/cannonlake: Add _DSM method for SD controller ......................................................................
Patch Set 2: Code-Review+1
(11 comments)
mostly nits about asl style.
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... File src/soc/intel/cannonlake/acpi/scs.asl:
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 107: ( Space before (
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 109: ( same here
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 111: ( same here
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 128: ( same here
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 129: ( same here
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 139: ( same here
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 141: } Space before }
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 141: ( same here
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 141: { spaces around {
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 150: ( same here
https://review.coreboot.org/#/c/33233/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 152: ( same here