Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38443 )
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@9 PS2, Line 9: second seconds
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@9 PS2, Line 9: 200 second 3 + x minutes? The value is in ms, and you change it to 2000 seconds.
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@10 PS2, Line 10: it meet Fits on line above.
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@11 PS2, Line 11: What is the current error with fishbowl 1000? How much does the temperature rise?
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@14 PS2, Line 14: check Fits on line above.