29 Dec
2020
29 Dec
'20
11:28 p.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48862 )
Change subject: drivers/intel/gma: Include gfx.asl by default for all platforms... ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48862/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48862/5//COMMIT_MSG@7 PS5, Line 7: ... : : which
nit: maybe move the ... […]
I feel like it makes more sense to have in the subject line since without it it's unclear that the statement has an additional condition attached
--
To view, visit https://review.coreboot.org/c/coreboot/+/48862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie71bd5fc7acd926b7ce7da17fbc108670fd453e0
Gerrit-Change-Number: 48862
Gerrit-PatchSet: 7
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Dec 2020 21:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment