Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33233 )
Change subject: soc/intel/cannonlake: Add _DSM method for SD controller
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33233/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33233/1//COMMIT_MSG@8
PS1, Line 8:
Can you please add the BUG= field.
https://review.coreboot.org/#/c/33233/1/src/soc/intel/cannonlake/acpi/scs.as...
File src/soc/intel/cannonlake/acpi/scs.asl:
https://review.coreboot.org/#/c/33233/1/src/soc/intel/cannonlake/acpi/scs.as...
PS1, Line 106: (
Please use space before ( here and in rest of the uses in this file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15090ed9f9bc90b35dfcba47c913e3d37b799d0b
Gerrit-Change-Number: 33233
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Medha Garima
medha.garima@intel.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Jun 2019 06:27:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment