Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35156 )
Change subject: nb/intel/x4x: Do cosmetic fixes ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35156/2/src/northbridge/intel/x4x/d... File src/northbridge/intel/x4x/dq_dqs.c:
https://review.coreboot.org/c/coreboot/+/35156/2/src/northbridge/intel/x4x/d... PS2, Line 100:
Why are there newlines here?
When a bunch of lines are packed together, I tend to mix them up: while reading, I jump to the line immediately above or below without realizing. The newlines chop this wall of text into sentence-like blocks:
98: If pi is less than 6, then increment pi by 1.
101: Else, if tap is less than max_tap_val, then set pi to 0 and increment tap by 1.
105: Else, if clk_delay is less than 2, then set pi and tap to 0 and increment clk_delay by 1.
110: Else, if coarse is less than 1, then set pi and tap to 0, decrement clk_delay by 1 and increment coarse by 1.
116: Otherwise, return CB_ERR.