Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46054 )
Change subject: mb/intel/adlrvp: Add initial ADL-P mainboard code ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46054/2/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/46054/2/src/mainboard/intel/adlrvp/... PS2, Line 2: SI_ALL@0x0 0x1081000 {
Specifying the offset and size of everything isn't necessary. […]
Ack
https://review.coreboot.org/c/coreboot/+/46054/2/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/variants/adlrvp_p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/46054/2/src/mainboard/intel/adlrvp/... PS2, Line 28: device pci 0d.1 off end # USB xDCI (OTG)
nit: please align the `end` keywords
Ack