Attention is currently required from: Tarun Tuli, Kapil Porwal, Lean Sheng Tan, Werner Zeh.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69032 )
Change subject: soc/intel: Include <cpu/cpu.h> instead of <arch/cpu.h>
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Thank you
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/69032/comment/fa337a03_00e1c84f
PS1, Line 11: #include <intelblocks/cse_layout.h>
: #include <intelblocks/cse.h>
nit: I would leave this two ion their original order, looks somehow weird this way...But up to you.
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69032
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7da9c672ee230dfaebd943247639b78d675957e4
Gerrit-Change-Number: 69032
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 07:12:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment