Attention is currently required from: Felix Singer, Tim Crawford, Patrick Rudolph, Jeremy Soller, Christian Walter, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60203 )
Change subject: mainboard: Fix DPTF device state in the devicetree on CFL boards
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60203/comment/7ffeaae0_5848c1db
PS2, Line 12: * google/hatch
Actually, it's only true for half of the variants. Those that
use static ASL code for DPTF, it seems. I don't fully understand
the pattern, but it still seems to me that the device was `off`
by accident. Would be nice to have one of the affected variants
tested.
https://review.coreboot.org/c/coreboot/+/60203/comment/5a07a3b7_ebe4c5c3
PS2, Line 14: Thus, set it to on to make the resource allocator aware of it.
It also activates `soc/intel/common/block/dtt/dtt.c`. This simply
hooks up scan_generic_bus(). However, that shouldn't matter if
only variants with static ASL code / without a dummy device below
04.0 are affected.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60203
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I561598c252c5da64ece569c6ba336852e713ccab
Gerrit-Change-Number: 60203
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sat, 18 Dec 2021 12:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment