Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40259 )
Change subject: soc/intel/common: Add _DSM methods for LPIT table
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40259/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40259/4//COMMIT_MSG@11
PS4, Line 11:
: LPIT table is hardcoded in this patch but the proper way to implement
: is to use inject_dsdt to make the _DSM methods available for soc's to
: implement.
Right, let me try to address it. We can't dodge this forever. […]
I think it's fine to address it in another CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib58f2e33a33bac9cc5f6aca28e85a8066413a5cf
Gerrit-Change-Number: 40259
Gerrit-PatchSet: 4
Gerrit-Owner: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Thu, 16 Apr 2020 16:53:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-MessageType: comment