Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33189 )
Change subject: soc/intel/common: Skip SoC GT programming based on CONFIG_SKIP_GRAPHICS_ENABLING ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33189/1/src/soc/intel/icelake/graphics.c File src/soc/intel/icelake/graphics.c:
https://review.coreboot.org/#/c/33189/1/src/soc/intel/icelake/graphics.c@48 PS1, Line 48: DDI_A_4_LANES
i don't understand what for you are arguing? as i have mentioned in commit msg this CL is to skip GT […]
Subrata needs to explain that bit better about the internal granularity of this driver needed.
Yes Aaron, you are right, if i remember correctly IGD DID: 8a71 was common for GT and non GT socs till the time we have started seeing hang in coreboot while executing graphics_soc_init(). we got to know later that few parts doesn't have GT enable, now when delivering single coreboot for all parts how we can distinguish which part has GT and non GT, for that purpose we have decided to skip those GT related programming for early parts when soc user selects SKIP_GRAPHICS_ENABLING kconfig. Plan is to remove this select option after we know all parts has fused graphics in it. i hope i'm clear on requirement parts