Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32880 )
Change subject: soc/fsp_broadwell_de: fix flashconsole support for platform
......................................................................
Patch Set 1:
Patch Set 1:
What’s the status of this change-set?
I was waiting on a consensus on whether to revert the sb/common/spi version to using CAR global, or to use this patchset
Hey Matt. I would like to get that done, it rots too long already. What would be your preference? Keep the specific file for broadwell-de or go back to the common driver and enable early SPI there?
@Kyösti: You might have a better history knowledge on the CAR_GLOBAL issues that have led to this inconsistence?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72e5db1583199b5ca4b6ec54661282544d326f0f
Gerrit-Change-Number: 32880
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Sep 2019 08:17:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment