30 Mar
2022
30 Mar
'22
8:41 p.m.
Attention is currently required from: Arthur Heymans, Julius Werner, Yu-Ping Wu. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56122 )
Change subject: Makefile.inc: Add the x86 bootblock as a regular cbfs file ......................................................................
Patch Set 3:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56122/comment/9e2a2465_b0d24f29 PS3, Line 840: This top aligns files of type bootblock, assuming that only x86 uses those Instead of making this assumption, maybe add a Kconfig option that's selected by x86? Up to you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56122
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4de9d7fedf1ae5a37a3310dd42eb07b44c030930
Gerrit-Change-Number: 56122
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Wed, 30 Mar 2022 17:41:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment