Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37214 )
Change subject: lib: Fix FMAP cache on FSP1.0 platforms ......................................................................
Patch Set 2:
yes it does. I just thought if somebody wants it back in, we could use this patch. Do you see any value? if you think it does not worth the trouble I am ok dropping this
You mean you want to use the FMAP cache on FSP1.0 (instead of disabling it)? You won't get that like this... you're checking car_active() which will always be true at the time where you'd need the pre-RAM cache. After car_active() is false, you're already using the other cache in CBMEM anyway.
If you really wanted to make it usable instead you could check stage macros to enable it only during ENV_BOOTBLOCK and ENV_VERSTAGE, but I don't think that's worth it. (Truth be told, I would expect the feature doesn't add much on Intel platforms in general since the SPI memory mapping hardware is probably already caching the area internally anyway. I mostly wrote it for Arm and as a pre-requisite that we'll eventually need for TOCTOU-safe verification.)