Attention is currently required from: Angel Pons, Subrata Banik, Aamir Bohra.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51026 )
Change subject: mb/intel/shadowmountain: Enable Type-C subsystem
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51026/comment/a0d21805_d7fd1b40
PS1, Line 12: ..
One period is enough
Done
File src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/51026/comment/1e0301d1_826f1db9
PS1, Line 99: [PchSerialIoIndexGSPI3] = 0,
I guess this wasn't meant to be re-added?
yep :(
https://review.coreboot.org/c/coreboot/+/51026/comment/f604b295_5fb2c331
PS1, Line 106: [PchSerialIoIndexGSPI3] = 0,
Same
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51026
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaf1170ca718a14d24b773a4a85516e0bbfbb569
Gerrit-Change-Number: 51026
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Tue, 23 Feb 2021 14:04:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment