HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42201 )
Change subject: soc/intel/skylake: Check Kconfig symbols in C instead of preprocessor
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42201/1/src/soc/intel/skylake/acpi....
File src/soc/intel/skylake/acpi.c:
https://review.coreboot.org/c/coreboot/+/42201/1/src/soc/intel/skylake/acpi....
PS1, Line 1:
new line ?
https://review.coreboot.org/c/coreboot/+/42201/1/src/soc/intel/skylake/acpi....
PS1, Line 184: else {
maybe not needed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42201
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6601bfd6e7a11eca6bbc32f6757c165ba5a4cff
Gerrit-Change-Number: 42201
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 08 Jun 2020 16:39:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment